Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix cursor of some footer links and replace twitter with mastodon #2181

Closed
wants to merge 19 commits into from

Conversation

Siedlerchr
Copy link
Member

Fixes #2010
Fixes #1978

@tobiasdiez
Copy link
Member

Nice workaround (if this indeed fixes the cursor issue)!

Prettier is complaining though

@Siedlerchr
Copy link
Member Author

I did not touch the other files the linter is complaining about They were failing before. I tested this with Firefox inspector.

@Siedlerchr
Copy link
Member Author

I fixed the f*cking deployment by switching to ubuntu and you now force pushed all the changes! Are you serious?

@tobiasdiez tobiasdiez changed the title Fix cursor and replace twitter with mastodon fix: fix cursor of some footer links and replace twitter with mastodon Aug 22, 2023
@tobiasdiez
Copy link
Member

Can you please rebase this (and fix the prettier error if it is still there). Thanks!

@tobiasdiez tobiasdiez added the status: needs changes PR needs further changes before it can be merged label Sep 4, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

* upstream/main: (31 commits)
  chore: add progress bar to journal data update script (#2182)
  chore: Bump pinia from 2.1.4 to 2.1.6 (#2153)
  chore: Bump concurrently from 8.2.0 to 8.2.1 (#2200)
  chore: Bump the vue group with 7 updates (#2212)
  chore: Bump @yaireo/tagify and @types/yaireo__tagify (#2195)
  chore: Bump the eslint group with 3 updates (#2218)
  chore: replace last patch-package patch by yarn patch (#2224)
  chore: split deploy workflow (#2223)
  chore: enable organize-imports prettier plugin (#2220)
  chore: extend nuxt dependabot group by zod and ufo (#2221)
  chore: Bump the vitest group with 3 updates (#2210)
  chore: Bump autoprefixer from 10.4.14 to 10.4.15 (#2198)
  chore: Bump the prisma group with 2 updates (#2190)
  chore: Bump the prettier group with 2 updates (#2206)
  chore: Bump redis from 4.6.7 to 4.6.8 (#2191)
  chore: Bump typescript from 5.1.6 to 5.2.2 (#2197)
  chore: Bump the graphql group with 9 updates (#2217)
  chore: Bump the types group with 3 updates (#2213)
  chore: Bump actions/checkout from 3.5.3 to 3.6.0 (#2186)
  chore: fix version regex (#2216)
  ...

# Conflicts:
#	.github/workflows/deploy.yml
fix newline
@Siedlerchr
Copy link
Member Author

I fixed the vue file. I didn't touch the other files and have no idea of this any types there

…into fixHyerlinksCuzrsor

* 'fixHyerlinksCuzrsor' of github.com:JabRef/JabRefOnline:
  Update deploy.yml
@tobiasdiez
Copy link
Member

Thanks but the linter is still falling. Also the changes outside the footer file shouldn't be there, right?

@Siedlerchr
Copy link
Member Author

the other changes were made to make sure the downloads to to fosshub directly

@tobiasdiez
Copy link
Member

tobiasdiez commented Sep 5, 2023

And what's the point of this? It's a feature that the correct download starts immediately (with space for improvements for Linux and macos)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs changes PR needs further changes before it can be merged status: safe to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouse cursor shows text cursor instead of hand symbol Add Mastodon link
2 participants