Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #7425

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Fix typos #7425

merged 2 commits into from
Feb 8, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Feb 7, 2021

#7181 will take a long time until it will be eventually merged. There, some non-related typo fixed were fixed. This PR extract these fixes into a separate PR.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 7, 2021
k3KAW8Pnf7mkmdSMPHz27
k3KAW8Pnf7mkmdSMPHz27 approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks typo-free to me (which I guess is the point of the PR?)

CHANGELOG.md Show resolved Hide resolved
@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

Or do you want to keep this PR going and add more typo-fixes along the way?

@calixtus
Copy link
Member

calixtus commented Feb 8, 2021

Lets merge this one, since it's done. If we encounter other typos, we'll fix them in other PRs, either dedicated typo PRs or together with other fixes and changes.

@calixtus calixtus merged commit 8a95a82 into master Feb 8, 2021
@calixtus calixtus deleted the fix-typos branch February 8, 2021 19:09
Siedlerchr added a commit that referenced this pull request Feb 21, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into ikonlimaterial
ec7b9e4 
* upstream/master:
  Fix typos (#7425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koppor @k3KAW8Pnf7mkmdSMPHz27 @calixtus