-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install script fixes - better support for fresh installs of apt-based distros. #186
base: main
Are you sure you want to change the base?
Conversation
I've looked over the changes you've made, and there some things I'd like to bring up.
|
Yes, you're bringing up valid points. The keyboard thing seems to have slipped through due to issues with the .gitignore. The thing about effort on other platforms is valid too but I'm solving issues related to my own install, whereas I can't test it on others. Finally on the separate checks script, that would be a good idea, but the added untested failure points is not worth it for me. More moving parts means more ways to break something. Yes sudo is redundant, will see what i can do about it. Cheers. |
I overlooked && exit 1 fails after the modinfo check. Should work better now. |
This PR is for Debian-based distros only, so we don't have to merge it if it is missing the other distros |
So far it's only limitation is that it only supports the apt package manager. In principle I think what's being done here is a good idea. How many/which package managers need to be supported for this to be merged? |
We don't need to write a script to check dependencies since there are various package managers. Instead, we can create binary packages for different package managers, such as You can find the binary package here: Predator-Sense-CLI-8.0-1-any.pkg.tar.zst. Instructions on how to build the binary package can be found here. visit Exodia OS |
Being that you are the developer of Exodia OS, I can see how creating a package for package managers is viable option for you. Unless we want to put the extra effort into creating packages every time there is an update for distros that use zypper, dnf, apt, pacman, and all the other package managers I'm forgetting, plus getting them added to the repos for those distros, I'm not sure this is sustainable. As an arch user I don't care if there are special features for debian based distros, the most important thing is we have functionality for as many as possible, without being a detriment to anyone. If apt users get to have make installed for free without needing to deal with it themselves, I don't see what the issue is. If I want that functionality I can add it myself. |
Fixed merge issues |
Good to see this branch is still in development. When I made fixes for clang kernels I was using a live usb to try and test the changes I made. This would have saved me a headache |
Check and enable kernel module - platform_profile on fresh installs.
Also attempts to auto-install make if not present.