Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to yarn v4 #1225

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Switch to yarn v4 #1225

wants to merge 8 commits into from

Conversation

gflores-jahia
Copy link
Contributor

JIRA

https://jira.jahia.org/browse/PROJECT-XXX

Description

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

@gflores-jahia gflores-jahia requested a review from a team as a code owner June 6, 2024 20:40
@cedmail
Copy link
Member

cedmail commented Jun 6, 2024

@gflores-jahia maybe it should be a draft for now?

cedmail
cedmail suggested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@cedmail cedmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting, compiling issues

@gflores-jahia gflores-jahia marked this pull request as draft June 6, 2024 20:47
@gflores-jahia
Copy link
Contributor Author

@cedmail yes indeed, sorry I forgot it auto-assigns the reviewers

@gflores-jahia
Copy link
Contributor Author

Modify resolutions and upgrade schema-utils which is what's requiring old (vulnerable) ajv package GHSA-v88g-cgmw-v5xw

> yarn why ajv
├─ schema-utils@npm:0.3.0
│  └─ ajv@npm:5.5.2 (via npm:^5.0.0)

Also resolution can be set on yarn.lock using:

yarn set resolution schema-utils@npm:^0.3.0 npm:1.0.0 (take note of npm qualifier otherwise it throws Error: [email protected] isn't supported by any available resolver)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedmail cedmail cedmail requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gflores-jahia @cedmail