Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOON-475: Add components Fieldset & DynamicFieldset #478

Merged
merged 4 commits into from
Jan 21, 2025
Merged

MOON-475: Add components Fieldset & DynamicFieldset #478

merged 4 commits into from
Jan 21, 2025

Conversation

Eevolee
Copy link
Contributor

@Eevolee Eevolee commented Jan 10, 2025

JIRA

https://jira.jahia.org/browse/MOON-475

Description

Add components Fieldset & DynamicFieldset

@Eevolee Eevolee requested a review from ffffffelix January 10, 2025 15:36
ffffffelix
ffffffelix requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@ffffffelix ffffffelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be great to clicking on the label or description to change the switch.
You can do it with a label with a for attribute which match the id of the Switch.

src/components/Fieldset/DynamicFieldset/ControlledDynamicFieldset.tsx Outdated Show resolved Hide resolved
src/components/Fieldset/DynamicFieldset/ControlledDynamicFieldset.tsx Outdated Show resolved Hide resolved
src/components/Fieldset/DynamicFieldset/ControlledDynamicFieldset.tsx Outdated Show resolved Hide resolved
src/components/Fieldset/DynamicFieldset/DynamicFieldset.types.ts Outdated Show resolved Hide resolved
src/components/Fieldset/DynamicFieldset/DynamicFieldset.types.ts Outdated Show resolved Hide resolved
src/components/Fieldset/Fieldset.tsx Outdated Show resolved Hide resolved
src/components/Fieldset/Fieldset.tsx Outdated Show resolved Hide resolved
src/components/Fieldset/Fieldset.types.ts Show resolved Hide resolved
src/components/Fieldset/DynamicFieldset/DynamicFieldset.stories.tsx Outdated Show resolved Hide resolved
src/components/Fieldset/DynamicFieldset/ControlledDynamicFieldset.tsx Show resolved Hide resolved
@ffffffelix ffffffelix added the minor Increment the minor version when merged label Jan 13, 2025
@Eevolee Eevolee requested a review from ffffffelix January 20, 2025 15:52
@Eevolee Eevolee requested a review from ffffffelix January 21, 2025 08:42
@Eevolee Eevolee merged commit f2d4708 into develop Jan 21, 2025
3 checks passed
@Eevolee Eevolee deleted the MOON-475 branch January 21, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffffffelix ffffffelix ffffffelix approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eevolee @ffffffelix