New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplified on_hotkey_main, make use of spawn-item action, improved icons #11

Open

ickputzdirwech wants to merge 1 commit into JeffSpindler:master from ickputzdirwech:master

ickputzdirwech commented Mar 2, 2021

simplified on_hotkey_main

player.clear_cursor() attempts to clear the cursor and returns true if it succeeds.
player.cursor_stack.valid_for_read is an extra precaution that isn't even necessary as far as I know
player.cursor_stack.set_stack({name = "max-rate-calculator"}) type or count isn't needed

make use of spawn-item action

the item is directly spawned by the shortcut. No need to do anything in control.lua
the only disadvantages are, that the first-time-message doesn't work, but that's not really needed imo.

improved icons

The two shortcuts can easily distinguished since one is grey and one is blue.
The question mark icon is replaced by a white calculator.


          simplified on_hotkey_main, make use of spawn-item action, improved icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet