fix get_cash_conversion_efficiency, ratio is using operating cash flo… #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w found in cash flow statement, not income statment. seems a typo in trailing case.
|
This is what happens when I am too lazy to write tests! Thank you for catching this, will do a new release tomorrow. |
|
Fix is in v1.7.5: 
|
|
thanks, great stuff🚀🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, seems got a typo in function get_cash_conversion_efficiency. Operating Cash Flow is found in cash flow statement, not income statement. The trailing case uses income statement which should be incorrect.