chore(manager): remove duplicate lit module #2334
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current findings:
override
feature instead - at first to force all our dependencies to use lit@3 and@lit/[email protected]
. This didn't work as npm can't force versions upon dependencies that those dependencies don't accept:override
to enforce [email protected] instead, as it seemed that was the version all our dependencies would accept:As you can see, this successfully removed the multiple versions of lit warning from the tests!
mwc
component as a workaround. This further lends credence to the idea that@material/web
(the more modernmd
prefixed web components) don't play well with the older lit versions and that upgrading to 3 will ultimately fix this issue.At this point, I think our only option is to use Webpack to force resolution of lit throughout our build (something I was trying to avoid):
This is a little tricky given our monorepo structure, but doable.
Out of scope would be to switch back to yarn, as yarn 2+ has really precise controls for managing the dependencies of your dependencies.
Also, we should probably let the lit team (?) know about the
overrides
trick I discovered? That way they can update their documentation to be more helpful.