fix snippets tests on linux

Signed-off-by: Jos Verlinde <[email protected]>
Josverl · Oct 15, 2023 · 897dd24 · 897dd24
1 parent 049d2bc
commit 897dd24
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/snippets/check_stm32/check_pyb.py b/snippets/check_stm32/check_pyb.py
@@ -133,7 +133,7 @@
 
 
 can = CAN(1, CAN.LOOPBACK)
-can.setfilter(0, CAN.LIST16, 0, (123, 124, 125, 126))
+can.setfilter(0, CAN.LIST16, 0, (123, 124, 125, 126)) # stubs-ignore : version<=1.18.0
 can.send("message!", 123)  # send a message with id 123
 can.recv(0)  # receive message on FIFO 0
 

diff --git a/snippets/conftest.py b/snippets/conftest.py
@@ -153,7 +153,7 @@ def install_stubs(
         cmd = f"pip install {stubsource} --target {tsc_path} --no-user"
 
     try:
-        subprocess.run(cmd, shell=False, check=True, capture_output=True, text=True)
+        subprocess.run(cmd, shell=True, check=True, capture_output=True, text=True)
     except subprocess.CalledProcessError as e:
         # skip test if source connot be found
         print(f"{e.stderr}")

diff --git a/snippets/test_snippets.py b/snippets/test_snippets.py
@@ -36,7 +36,7 @@
 }
 
 SOURCES = ["local", "pypi"]
-VERSIONS = ["latest", "v1.21.0", "v1.20.0"]  # , "v1.19.1"]
+VERSIONS = ["latest", "v1.21.0", "v1.20.0", "v1.19.1", "v1.18"]
 
 
 def pytest_generate_tests(metafunc: pytest.Metafunc):
@@ -156,7 +156,7 @@ def test_pyright(
         try:
             # run pyright in the folder with the check_scripts to allow modules to import each other.
             result = subprocess.run(
-                cmd, shell=False, capture_output=True, cwd=snip_path.as_posix()
+                cmd, shell=True, capture_output=True, cwd=snip_path.as_posix()
             )
         except OSError as e:
             raise e