Skip to content

Commit

Permalink
Fix some type instabilities and other fixes (#119)
Browse files Browse the repository at this point in the history
  • Loading branch information
@DanielVandH
DanielVandH authored Jul 1, 2024
2 parents 6910c27 + 8b63858 commit 42700ed
Show file tree
Hide file tree
Showing 118 changed files with 2,121 additions and 3,129 deletions.
1 change: 1 addition & 0 deletions .github/workflows/CI.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ jobs:
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: lcov.info
fail_ci_if_error: false
docs:
name: Documentation
Expand Down
28 changes: 28 additions & 0 deletions .github/workflows/DocCleanup.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Doc Preview Cleanup

on:
pull_request:
types: [closed]

jobs:
doc-preview-cleanup:
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- name: Checkout gh-pages branch
uses: actions/checkout@v3
with:
ref: gh-pages
- name: Delete preview and history + push changes
run: |
if [ -d "previews/PR$PRNUM" ]; then
git config user.name "Documenter.jl"
git config user.email "[email protected]"
git rm -rf "previews/PR$PRNUM"
git commit -m "delete preview"
git branch gh-pages-new $(echo "delete history" | git commit-tree HEAD^{tree})
git push --force origin gh-pages-new:gh-pages
fi
env:
PRNUM: ${{ github.event.number }}
2 changes: 2 additions & 0 deletions Project.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
EnumX = "1.0"
ExactPredicates = "2.2"
julia = "1"
Random = "1"
Test = "1"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
[![Dev](https://img.shields.io/badge/docs-dev-blue.svg)](https://JuliaGeometry.github.io/DelaunayTriangulation.jl/dev/)
[![Coverage](https://codecov.io/gh/JuliaGeometry/DelaunayTriangulation.jl/branch/main/graph/badge.svg)](https://codecov.io/gh/JuliaGeometry/DelaunayTriangulation.jl)
[![DOI](https://zenodo.org/badge/540660309.svg)](https://zenodo.org/badge/latestdoi/540660309)
[![Aqua QA](https://raw.githubusercontent.com/JuliaTesting/Aqua.jl/master/badge.svg)](https://github.com/JuliaTesting/Aqua.jl)

This is a package for constructing Delaunay triangulations and Voronoi tessellations of planar point sets. Supports unconstrained and constrained triangulations, mesh refinement, triangulation of curve bounded domains, Voronoi tessellations, and clipped and centroidal Voronoi tessellations. All geometric predicates are computed via [ExactPredicates.jl](https://github.com/lairez/ExactPredicates.jl). To install the package, do

Expand Down
Loading

4 comments on commit 42700ed

@DanielVandH
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/110142

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.0.4 -m "<description of version>" 42700ed5c416c4f437c7d0f220596b7014e4d1a9
git push origin v1.0.4

@DanielVandH
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

Release notes:

Nothing breaking, but some various changes

  • Fixes some issue with type instabilities
  • Adds construct_polygon_hierarchy to the public API list (it was already intended to be there)
  • All computations are now in the provided precision except for the triangle area and circumcenter which are done in Float64. A warning is given when a non-Float64 precision is given.
  • Closes Weird hanging behaviour with Val(true) in kwarg #118
  • Redesigns the Polygon struct to have an is_circular field, avoiding the need for views
  • Completely refactors validate_triangulation. Still only lives in the test files though. Maybe one day it can live inside the package itself incase users somehow have a use for it..
  • Clean up the runtests.jl file, and make sure that the README/docs are fully tested
  • Use Aqua and fix ambiguities
  • Remove accidental piracy of minimum(::Nothing)
  • Remove CI spam from method redefinitions
  • Fix some issues with doc images and some typos
  • Fix Invalid convex_hull when points are repeated #109

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/110142

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.0.4 -m "<description of version>" 42700ed5c416c4f437c7d0f220596b7014e4d1a9
git push origin v1.0.4

Please sign in to comment.