-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some type instabilities and other fixes #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld rather than using views
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 95.06% 95.31% +0.25%
==========================================
Files 92 92
Lines 9095 9145 +50
==========================================
+ Hits 8646 8717 +71
+ Misses 449 428 -21 ☔ View full report in Codecov by Sentry. |
…ectly, execute literate scripts, refactor runtests.jl file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
construct_polygon_hierarchy
to the public API list (it was already intended to be there)Float64
. A warning is given when a non-Float64 precision is given.Val(true)
in kwarg #118Polygon
struct to have anis_circular
field, avoiding the need forviews
validate_triangulation
. Still only lives in the test files though. Maybe one day it can live inside the package itself incase users somehow have a use for it..minimum(::Nothing)
convex_hull
when points are repeated #109