Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some type instabilities and other fixes #119

Merged
merged 31 commits into from
Jul 1, 2024
Merged

Fix some type instabilities and other fixes #119

merged 31 commits into from
Jul 1, 2024

Conversation

DanielVandH
Copy link
Member

@DanielVandH DanielVandH commented Jun 30, 2024

  • Fixes some issue with type instabilities
  • Adds construct_polygon_hierarchy to the public API list (it was already intended to be there)
  • All computations are now in the provided precision except for the triangle area and circumcenter which are done in Float64. A warning is given when a non-Float64 precision is given.
  • Closes Weird hanging behaviour with Val(true) in kwarg #118
  • Redesigns the Polygon struct to have an is_circular field, avoiding the need for views
  • Completely refactors validate_triangulation. Still only lives in the test files though. Maybe one day it can live inside the package itself incase users somehow have a use for it..
  • Clean up the runtests.jl file, and make sure that the README/docs are fully tested
  • Use Aqua and fix ambiguities
  • Remove accidental piracy of minimum(::Nothing)
  • Remove CI spam from method redefinitions
  • Fix some issues with doc images and some typos
  • Fix Invalid convex_hull when points are repeated #109

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 95.58233% with 11 lines in your changes missing coverage. Please review.

Project coverage is 95.31%. Comparing base (6910c27) to head (8b63858).

Files Patch % Lines
src/data_structures/trees/bst.jl 55.55% 4 Missing ⚠️
src/geometric_primitives/boundary_nodes.jl 0.00% 2 Missing ⚠️
src/algorithms/intersections/rtree.jl 50.00% 1 Missing ⚠️
src/algorithms/triangulation/mesh_refinement.jl 94.44% 1 Missing ⚠️
src/data_structures/trees/rtree.jl 88.88% 1 Missing ⚠️
...structures/triangulation/methods/boundary_nodes.jl 80.00% 1 Missing ⚠️
src/utils/utils.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   95.06%   95.31%   +0.25%     
==========================================
  Files          92       92              
  Lines        9095     9145      +50     
==========================================
+ Hits         8646     8717      +71     
+ Misses        449      428      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVandH DanielVandH merged commit 42700ed into main Jul 1, 2024
6 checks passed
@DanielVandH DanielVandH deleted the instab branch July 7, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird hanging behaviour with Val(true) in kwarg Invalid convex_hull when points are repeated
1 participant