Enable CircleCI

.circleci/config.yml

@@ -0,0 +1,30 @@
+version: 2
+jobs:
+  build:
+    working_directory: /go/src/github.com/Juniper/contrail
+    docker:
+      - image: circleci/golang:1.9
+      - image: circleci/mysql:5.7
+        environment:
+          - MYSQL_ROOT_PASSWORD=contrail123
+
+    steps:
+    - checkout
+    - run:
+        name: install mysql client
+        command: sudo apt install mysql-client
+    - run:
+        name: install deps
+        command: ./tools/deps.sh
+    - run:
+        name: lint
+        command: ./tools/lint.sh
+    - run:
+        name: Wait for db
+        command: dockerize -wait tcp://localhost:3306 -timeout 1m
+    - run:
+        name: Reset database
+        command: ./tools/reset_db.sh
+    - run:
+        name: Run Test
+        command: make test

pkg/apisrv/server.go

@@ -131,6 +131,7 @@ func (s *Server) Run() error {
 	return nil
 }
 
+//Close closes server resources
 func (s *Server) Close() error {
 	return s.DB.Close()
 }

pkg/common/api.go

@@ -6,7 +6,7 @@ import (
 	"github.com/labstack/echo"
 )
 
-//REST API defines handlers for REST API calls.
+//RESTAPI defines handlers for REST API calls.
 type RESTAPI interface {
 	Path() string
 	LongPath() string

pkg/common/schema.go

@@ -59,7 +59,7 @@ func (c ColumnConfigs) Less(i, j int) bool {
 	return strings.Compare(strings.Join(c[i].ParentColumn, "")+c[i].Column, strings.Join(c[j].ParentColumn, "")+c[j].Column) > 0
 }
 
-func (c ColumnConfigs) ShortenColumn() {
+func (c ColumnConfigs) shortenColumn() {
 	sort.Sort(c)
 	if len(c) < 2 {
 		return
@@ -418,7 +418,7 @@ func (api *API) resolveAllSQL() error {
 		if err != nil {
 			return err
 		}
-		s.Columns.ShortenColumn()
+		s.Columns.shortenColumn()
 	}
 	return nil
 }

tools/reset_db.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
 TOP=$(dirname "$0")
-mysql -uroot -pcontrail123 -e "drop database if exists contrail_test;"
-mysql -uroot -pcontrail123 -e "create database contrail_test;"
-mysql -uroot -pcontrail123 contrail_test < $TOP/init.sql
+mysql -uroot -pcontrail123 -h 127.0.0.1 -e "drop database if exists contrail_test;"
+mysql -uroot -pcontrail123 -h 127.0.0.1  -e "create database contrail_test;"
+mysql -uroot -pcontrail123 -h 127.0.0.1 contrail_test < $TOP/init.sql

tools/test_config.yml

@@ -1,6 +1,6 @@
 # Database configuraion. Only MySQL supported
 database:
-    connection: "root:contrail123@tcp(mysql:3306)/contrail_test"
+    connection: "root:contrail123@tcp(localhost:3306)/contrail_test"
     # Max Open Connections for MySQL Server
     max_open_conn: 100