Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ospf3 rules #1008

Open
wants to merge 1 commit into
base: jcloud
Choose a base branch
from
Open

Added ospf3 rules #1008

wants to merge 1 commit into from

Conversation

vvikramb
Copy link
Collaborator

@vvikramb vvikramb commented Jan 8, 2025

Rules added :

routing.ospf/check-ospf3-io-statistics
routing.ospf/check-ospf3-statistics

@@ -16,6 +16,30 @@ Ospf3NeighborStatsView:
ospf-neighbor-state: ospf-neighbor-state
instance-name: ../../ospf-instance-name

Ospf3StatsTable:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the output be large? do we require filtering using xslt?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ospf3 stats output can be large so xslt would be needed, but for ospf3 io-stats its at the protocol level so not needed.

@@ -0,0 +1,160 @@
/*
* Detects Osp3fIoStatsTable IO errors and notifies when anomalies are found.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requirement?

topic routing.ospf {
rule check-ospf3-io-statistics {
synopsis "OSPF3 IO statistics analyzer";
description "Monitors OSPF's I/O statistics";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSPF3?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to support ipv6 for ospf :

Below cli cmds, we need to use ospf3 for ipv6
show ospf3 statistics
show ospf3 io-statistics

field ospf-error {
sensor ospf-io-statistics-netconf {
path ospf-error;
data-if-missing {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we require data if missing ?

type integer;
description "Ospf IO error count";
}
field packets-read {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this field used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used, shall remove it.

sensors ospf-io-statistics-netconf;
operating-system junos {
products ACX {
platforms All {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platforms ALL is not valid

topic routing.ospf {
rule check-ospf3-statistics {
keys ospf-packet-type;
synopsis "ospf hello statistics analyzer";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ospf3?

@@ -0,0 +1,191 @@
/*
* Monitors OSPF3 hello packets and notifies anomalies when hello send and receive count
* is not increasing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REQ?

juniper {
operating-system junos {
products ACX {
platforms All {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is not valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants