Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KDDateTime: added a QVariant conversion operator #167

Merged
merged 2 commits into from
Mar 13, 2019
Merged

KDDateTime: added a QVariant conversion operator #167

merged 2 commits into from
Mar 13, 2019

Conversation

rokm
Copy link
Contributor

@rokm rokm commented Mar 12, 2019

This prevents the QVariant from being implicitly constructed using the base QDateTime, which leads to the loss of information (#123).

dfaure-kdab
dfaure-kdab requested changes Mar 13, 2019
View reviewed changes
Copy link
Member

@dfaure-kdab dfaure-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing an entry in doc/CHANGES_1_8_.txt

Thanks!

src/KDSoapClient/KDDateTime.h Outdated Show resolved Hide resolved
unittests/kddatetime/kddatetime.cpp Outdated Show resolved Hide resolved
rokm added 2 commits March 13, 2019 19:54
@rokm
Added unit test for KDDateTime to QVariant conversion
15522c0 
The test currently fails due to issue KDAB#123
@rokm
KDDateTime: added conversion operator to QVariant
5f73004 
This prevents implicit conversion to base QDateTime and loss of
time-zone information when passing the value as QVariant.

Fixes KDAB#123.
@rokm rokm force-pushed the kddatetime-variant branch from 1bc8d02 to 5f73004 Compare March 13, 2019 19:02
@rokm
Copy link
Contributor Author

rokm commented Mar 13, 2019

Revised version pushed.

@dfaure-kdab dfaure-kdab merged commit 25829ae into KDAB:master Mar 13, 2019
@rokm rokm deleted the kddatetime-variant branch March 14, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfaure-kdab dfaure-kdab dfaure-kdab requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rokm @dfaure-kdab