feat: detect more perf data file types in directory

[lievenhey]

Currently hotspot dir only opens perf.data files. This patch extends this to perf.data, perf.data.old and perf.data.perfparser files.

[GitMensch]

From the commit and PR title I've thought this to be about "open all perf.data/.perfparser files in the given directory"...

Not sure about perf.old.data... what do you think about moving it at least after perf.data.perfparser or take both out of that check and list dir directory for any files starting with "perf.data" or ending on ".perfparser"?

[lievenhey]

right, I changed the title so it is less misleading.

Not sure about perf.old.data... what do you think about moving it at least after perf.data.perfparser or take both out of that check and list dir directory for any files starting with "perf.data" or ending on ".perfparser"?

The intend of this feature is to emulate perf report. Therefor it doesn't make sense to open all files, only the newest one. But yes it should be not the second in the list. Lets see what @milianw has to say.

[GitMensch]

Opening the newest one would make it unlikely to load perf.old.data - but yes, I'd find it very nice if specifying the directory just takes the newest file per our file open- re

hotspot/src/mainwindow.cpp

Lines 287 to 294 in e6ce4c4

	QString MainWindow::queryOpenDataFile()
	{
	const auto filter = tr("Hotspot data Files (perf*.data perf.data.* *.perfparser *.perfparser.*);;"
	"Linux Perf Files (perf*.data perf.data.*);;"
	"Perfparser Files (*.perfparser *.perfparser.*);;"
	"All Files (*)");
	return QFileDialog::getOpenFileName(this, tr("Open File"), QDir::currentPath(), filter);
	}

Those are more files and currently there's no list dir, order by timestamp - can you please inspect adding this in this PR?

[milianw]

I agree with Simon, remove the .old and extract that into a single function that allows us to share that code

[lievenhey]

done

[lievenhey]

I just noticed, that this should not be merged, until #678 is merged. That PR makes opening compressed files much easier.
I should add compressed files to findPerfDataFiles

[GitMensch]

Note: the commit summary still says "perf.data.old" (I still suggest to actually do as the function name findPerfDataFiles - not search for a list of 2 fixed entries but to search for perf*.data perf.data.* *.perfparser *.perfparser.*, ordered by date (newest first).

[GitMensch]

perf report opens only a single file and I have lots of perf files in my directories...
I suggest to add either an optional integer limit or boolean newestFileOnly attribute to that function and use it here and above.

[milianw]

the loop breaks after the first opened file, so this is fine as-is

[GitMensch]

In theory this means that the caller may collect lots of file entries, just to drop all of those later.
That's not of a big issue currently as findPerfDataFiles() does not match our file open window (which I think it should, I'm creating a new issue to track it).

[milianw]

the loop breaks after the first opened file, so this is fine as-is