Refactor script dialog for pregression #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
narnaud
commented
Jun 17, 2024
narnaud
commented
- Refactor the ScriptDialogItem progression API, to ahve something simpler to use
- Add 2 examples to show how to do that in scripts
- Remove the uiFilePath property from ScriptDialog
narnaud
commented
Jun 17, 2024
- Simplify the progress dailog - Make it non-modal in interactive mode - Refactor the script API of ScriptDialog for handling progress: `setStepCount`, `firstStep` and `nextStep` (you can also use the `stepCount property` - Do some small cleanup and renaming in the code (remove `conversion`, as a script is not necessary a conversion script) - Add 2 examples to show an interactive script or a script with progressbar Change-Id: Iac6fad86df10aab5880618c827b1d7a723501e34
As this dialog is really used in a script, and not only for conversion. Change-Id: I34846acbcfb100c689ac0a68998d8569ec88ba05
Now that we have integration testing working, it's not needed anymore. This fix the default size for dialog script, which is now the size in designer. Change-Id: I0ac3d3660252854d20b7b3c9158ed9762f9ca74b
It's a good way to show how to handle script unit tests.
narnaud
force-pushed
the
refactor-script-dialog
branch
from
1001b59 to
a32e266
Compare
Montel
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.