show info rggrip not found #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Montel
commented
Oct 24, 2024
Montel
commented
- fix: fix crash when we create a new rc file (language is empty => assert)
- feat: show info/disable line when Ripgrep not found
|
There are 3 commits in this PR... |
narnaud
reviewed
Oct 24, 2024
| @@ -35,7 +50,7 @@ class FindInFilesPanel : public QWidget | |||
| void setupToolBar(); | |||
|
|
|||
| QWidget *const m_toolBar; | |||
| QTreeWidget *m_resultsDisplay; | |||
| FindInFilesTreeWidget *m_resultsDisplay; | |||
There was a problem hiding this comment.
This could stay a QTreeWidget here, if you move the check to the widget constructor
| @@ -45,6 +46,9 @@ FindInFilesPanel::FindInFilesPanel(QWidget *parent) | |||
| connect(m_resultsDisplay, &QTreeWidget::itemActivated, this, [this](QTreeWidgetItem *item, int) { | |||
| openFileAtItem(item); | |||
| }); | |||
| const bool available = Core::Project::instance()->isFindInFilesAvailable(); | |||
| m_searchInput->setEnabled(available); | |||
| m_resultsDisplay->setFindInFilesAvailable(available); | |||
There was a problem hiding this comment.
I don't think you need this here. Just put the check int he FindInFilesTreeWidget constructor, and leave the input enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.