Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38009 - content-override with deselect #11216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-bucher
Copy link
Contributor

@m-bucher m-bucher commented Nov 12, 2024

For host repository-sets with structured apt enabled setting content-overrides using bulk-action:
de-selecting deb-repos after using select-all has no effect.

What are the changes introduced in this pull request?

find_content_overrides() helper method must be adapted to work with one content for each katello-repo (#11058).

Considerations taken when implementing this change?

What are the testing steps for this pull request?

  1. Enable structured apt and have multiple structured deb-content
  2. Create Host attached to deb-content
  3. Try to reset content-overrides for that host in the following way:
  4. Select all content
  5. De-select part of the deb-repos
  6. Use bulk-action to override content state

ToDo

  • test Show all selected
  • write more unit tests 🙈

@m-bucher m-bucher force-pushed the fix_deselect_host_reposet_structured_apt branch 2 times, most recently from ae3d07f to 259acc9 Compare November 14, 2024 17:55
For host repository-sets with structured apt enabled setting
content-overrides using bulk-action:
de-selecting deb-repos after using select-all has no effect.
@m-bucher m-bucher force-pushed the fix_deselect_host_reposet_structured_apt branch from 5fc8308 to 67f179a Compare November 18, 2024 09:57
@m-bucher m-bucher marked this pull request as ready for review November 18, 2024 09:58
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-bucher can you elaborate more on step 1? How do I enable structured apt and do you have a url that has structured apt content to sync from?

@m-bucher
Copy link
Contributor Author

m-bucher commented Jan 9, 2025

@m-bucher can you elaborate more on step 1? How do I enable structured apt and do you have a url that has structured apt content to sync from?

@chris1984
Structured APT can be enabled by setting deb_enable_structured_apt to true.
After that new deb/apt (Root-)Repositories will use structured publishing. If you have pre-existing deb/apt repositories and want to convert them you have to use the katello:migrate_structure_content_for_deb rake task.

All deb/apt repositories you find on the internet are structured*. As in they define custom release/distribution names (e.g. stable, bookworm, noble) and components (e.g. main, non-free, universe).
Before structured-apt, Katello and Pulp always created release default with component all and just put all synched packages into that.
Now it mirrors the structure of the upstream repository (there should no longer be a dists/default folder in the repository published by Pulp/Katello).

* there are some weird flavours of APT-Repos out there, but the OS-repos of the distributions (Debian, Ubuntu, etc) are structured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants