feat: Hybrid StateDB for precompile support #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
drklee3
commented
Apr 15, 2024
•
drklee3
commented
- Hybrid StateDB design (state breaking)
- Fix for SetState deletion
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
drklee3
force-pushed
the
dl-hybrid-statedb
branch
2 times, most recently
from
745372a to
e94221d
Compare
removed from golangci-lint in v1.49.0
This reverts commit 1446f25.
without the goal of state compatibility, removes extra complexity and unneeded logic
Previous to this change, keeper SetState() only deletes when the
len(value) == 0. However, since value in the StateDB is a common.Hash{},
this will always be the HashLength. Deleting the value when the empty
hash is set will also ensure specific no-op changes will not be committed,
e.g. Creating a state, then deleting it in the same tx will result in
no state added.
drklee3
force-pushed
the
dl-hybrid-statedb
branch
from
24e4968 to
5030d2e
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.