Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hard-keeper-bot client updates #73

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

lbayas
Copy link

@lbayas lbayas commented Oct 8, 2024

  • fix issue where hard-keeper-bot is unable to connect via RPC to make calls and generates lots of logging in AWS
    Screenshot 2024-10-04 at 11 23 16 AM
  • infrastructure PR -- https://github.com/Kava-Labs/infrastructure/pull/651
  • created a new grpc_client with corresponding tests to return the information needed for hard keeper bot to perform liquidation activities

hard-keeper-bot example output:

getting market data at 12088795
getting price data at 12088795
getting borrow data at 12088795
getting deposit data at 12088795
100 positions fetched
96 borrowers to liquidate
sending liquidation for kava1ddshvcf3w9mnsdn5vcekswr9v9sh56e40fjnvcm2dqe85wp4w5c8swfkdvm8smp5vumhjh3hq63
sending liquidation for kava1ddshvcf3w9mnqdmp8y6nxatv0q6rjct9w3c8q6eew3nngmtw0f6r2vmjwae8zemxxaehv4tvwaa
sending liquidation for kava1ddshvcf3w9ekzvnydcmrs7fhwa4xsdmwv9ukxmfsvdehgemexp4kscm9ve48xen3vejxz2wtszl
sending liquidation for kava1ddshvcf3wyehgctyddexsvr30fex6ut8894rvvnj89ergcfsden8s7p5wdckgdt4vd48wf5r4aw
sending liquidation for kava1ddshvcf3w94xwdtkxumhvarg0q6kgmrvw3jns6enxver2ap5w3e82vrvxfcx6an6vehxxa36c4q
sending liquidation for kava1ddshvcf3w94nxmr6w3crgm35d458quphwpnk2unnvc68vapjdp6xkwryxumnw6n9wa6xk6604gz
sending liquidation for kava1ddshvcf3w958wvmedfsnvwfjdfkr26rywfm8wdmkxacnw6mwv4nku6phwdnrwctdwph8g2vdhzy
sending liquidation for kava1ddshvcf3w9jhxuek094ngd3jxg6kvmnxdfsnwmr5xpnrvd3jxankcmr9wacxc63nw3j8w6j0nx7
sending liquidation for kava1ddshvcf3wymrs6ecwek8zwrwdfaxv63n0fnxz6nkxuc8vcmtd4mxxut4x36rqdn9dvmk2urpcd3
sending liquidation for kava1ddshvcf3wym8xu34vyukkuncd3arsurhd56n2cmtxgmn2mnkxfkrvdnjxe3hwcmxxanrqe46ucg

@lbayas lbayas self-assigned this Oct 8, 2024
@lbayas lbayas requested review from nddeluca, boodyvo and drklee3 and removed request for nddeluca October 9, 2024 15:03
@lbayas lbayas marked this pull request as ready for review October 9, 2024 17:03
@lbayas lbayas requested review from sesheffield and karzak October 9, 2024 17:05
@lbayas
Copy link
Author

lbayas commented Oct 9, 2024

linter is failing due to change in go version to 1.23, not sure why

"google.golang.org/grpc/metadata"
)

type GrpcClient struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a team, we want to create fewer of these grpc client. we currently have many of them and they increase our maintenance overhead. overtime, they become slightly different copy-pastas of each other. can you update your code to use the canonical client from the kava repo?
https://github.com/Kava-Labs/kava/tree/master/client/grpc

i believe all of the methods included here already exist on that client. updating to use that also makes upgrading kava versions on these types of services much simpler 😄

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried updating to use kavaGrpc "github.com/kava-labs/kava/client/grpc" but am getting a plethora of dependency issues as a result. Will continue to investigate whats going on here

@lbayas lbayas requested review from DracoLi and removed request for boodyvo, nddeluca, sesheffield and karzak October 28, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants