-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hard-keeper-bot client updates #73
base: master
Are you sure you want to change the base?
Conversation
linter is failing due to change in go version to 1.23, not sure why |
"google.golang.org/grpc/metadata" | ||
) | ||
|
||
type GrpcClient struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a team, we want to create fewer of these grpc client. we currently have many of them and they increase our maintenance overhead. overtime, they become slightly different copy-pastas of each other. can you update your code to use the canonical client from the kava repo?
https://github.com/Kava-Labs/kava/tree/master/client/grpc
i believe all of the methods included here already exist on that client. updating to use that also makes upgrading kava versions on these types of services much simpler 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried updating to use kavaGrpc "github.com/kava-labs/kava/client/grpc"
but am getting a plethora of dependency issues as a result. Will continue to investigate whats going on here
hard-keeper-bot example output: