Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lesson 2. Practice solution #10

Open
wants to merge 4 commits into
base: Vladimir.Svistelnikov
Choose a base branch
from
Open

Lesson 2. Practice solution #10

wants to merge 4 commits into from

Conversation

svistelnikoff
Copy link

  • project created
  • guess number game implemented

@an1kh
02-Git: Add homework
dee892d 
Signed-off-by: Andriy Khulap <[email protected]>
an1kh
an1kh requested changes May 30, 2019
View reviewed changes
Copy link
Contributor

@an1kh an1kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reword commit messages according to the requirements.
Also fix format errors regarding the last empty line.

@an1kh an1kh added the changes requested The PR review revealed issues which should be fixed (set by reviewer). label May 30, 2019
@svistelnikoff svistelnikoff force-pushed the svistelnikoff@work-02 branch from 37e44fa to e152862 Compare June 4, 2019 21:30
@svistelnikoff
02-Git: Create empty project implementation
33c58a0 
Signed-off-by: Vladimir Svistelnikov <[email protected]>
@svistelnikoff
02-Git: Add parser logic
31c65f6 
Signed-off-by: Vladimir Svistelnikov <[email protected]>
@svistelnikoff
02-Git: Add game logic
7065123 
- added randomizer
- added result verifier

Signed-off-by: Vladimir Svistelnikov <[email protected]>
@svistelnikoff svistelnikoff force-pushed the svistelnikoff@work-02 branch from e152862 to 7065123 Compare June 9, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@an1kh an1kh an1kh requested changes

Assignees
No one assigned
Labels
changes requested The PR review revealed issues which should be fixed (set by reviewer).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svistelnikoff @an1kh