ci: Add GitHub Action for macOS building #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utzcoz
force-pushed
the
add-github-action-for-macOS-building
branch
3 times, most recently
from
a6c95e4 to
59994b2
Compare
rpavlik
requested changes
Sep 16, 2024
utzcoz
force-pushed
the
add-github-action-for-macOS-building
branch
6 times, most recently
from
5a4d5b6 to
ba12c55
Compare
|
|
utzcoz
force-pushed
the
add-github-action-for-macOS-building
branch
from
ba12c55 to
a3f71fc
Compare
|
@rpavlik PTAL. |
rpavlik
force-pushed
the
add-github-action-for-macOS-building
branch
from
a3f71fc to
16ec447
Compare
rpavlik
approved these changes
Sep 23, 2024
rpavlik
force-pushed
the
add-github-action-for-macOS-building
branch
from
16ec447 to
c71e1aa
Compare
humbletim/setup-vulkan-sdk's cache mechanism doesn't work for the same OS but different architectures. So this CL only tests with macOS 14 with arm64 architecture. Signed-off-by: utzcoz <[email protected]> Reviewed-by: Rylie Pavlik <[email protected]>
Signed-off-by: utzcoz <[email protected]> Reviewed-by: Rylie Pavlik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like humbletim/setup-vulkan-sdk's cache mechanism doesn't work for multiple jobs with the same OS but different architectures, like macOS 13 is x86_64 and macOS 14 is arm64. So this CL only adds macos-14 as runner OS and we can enable the macos-13 when we fixed the upstream cache supporting.