Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax DebugLine validation in NonSemantic.Shader.DebugInfo.100 #303

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Relax DebugLine validation in NonSemantic.Shader.DebugInfo.100 #303

merged 1 commit into from
Dec 18, 2024

Conversation

alan-baker
Copy link
Contributor

Fixes #302

  • Column End >= Column Start only if Line End == Line Start

@alan-baker
Relax DebugLine validation in NonSemantic.Shader.DebugInfo.100
cf7ffd8 
Fixes KhronosGroup#302

* Column End >= Column Start only if Line End == Line Start
@alan-baker alan-baker requested a review from Naghasan December 16, 2024 19:32
Naghasan
Naghasan approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@Naghasan Naghasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bashbaug
Copy link
Collaborator

Merging as discussed in the December 18th teleconference.

@bashbaug bashbaug merged commit c7398e3 into KhronosGroup:main Dec 18, 2024
2 checks passed
@alan-baker alan-baker deleted the debug-line-val branch December 18, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naghasan Naghasan Naghasan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect validation rule in NonSemantic.Shader.DebugInfo.100 DebugLine
3 participants
@alan-baker @bashbaug @Naghasan