Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tests for sycl_ext_oneapi_local_memory extension #958

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented Oct 7, 2024

Implement the tests from this test plan.

@0x12CC 0x12CC requested a review from a team as a code owner October 7, 2024 02:55
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@keryell, @ProGTX, do you want to take a look at this oneAPI vendor extension test before I merge it?

@bader
Copy link
Contributor

bader commented Dec 5, 2024

@0x12CC, please, address the review feedback and update your branch to enable ccache in CI.

@0x12CC
Copy link
Contributor Author

0x12CC commented Dec 5, 2024

Thanks for the review, @keryell! I've applied all of your suggestions.

@bader bader requested a review from keryell December 5, 2024 21:06
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bader bader merged commit 62ebcf2 into KhronosGroup:main Dec 6, 2024
8 checks passed
@0x12CC 0x12CC deleted the local_memory_tests branch December 6, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants