Skip to content

Commit

Permalink
Silent warnings on unused variables in some tests; make test UniqueHa…
Browse files Browse the repository at this point in the history
…ndleDefaultArguments part of the solution for 64 bit only. (#1704)
  • Loading branch information
asuessenbach authored Oct 18, 2023
1 parent 5b6f6fa commit 3e0d722
Show file tree
Hide file tree
Showing 5 changed files with 36 additions and 15 deletions.
10 changes: 10 additions & 0 deletions tests/ArrayProxy/ArrayProxy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,16 @@
// VulkanHpp Samples : ArrayProxy
// Compile test on using vk::ArrayProxy

#if defined( _MSC_VER )
// no need to ignore any warnings with MSVC
#elif defined( __clang__ )
# pragma clang diagnostic ignored "-Wunused-variable"
#elif defined( __GNUC__ )
# pragma GCC diagnostic ignored "-Wunused-but-set-variable"
#else
// unknow compiler... just ignore the warnings for yourselves ;)
#endif

#include <iostream>
#include <vulkan/vulkan.hpp>
#if ( 20 <= VULKAN_HPP_CPP_VERSION )
Expand Down
18 changes: 9 additions & 9 deletions tests/ArrayProxyNoTemporaries/ArrayProxyNoTemporaries.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,15 @@ std::vector<int> const getConstVector()
return { 1, 2 };
}

std::initializer_list<int> getInitializerList()
{
return { 1, 2 };
}

std::initializer_list<int> const getConstInitializerList()
{
return { 1, 2 };
}
//std::initializer_list<int> getInitializerList()
//{
// return { 1, 2 };
//}

//std::initializer_list<int> const getConstInitializerList()
//{
// return { 1, 2 };
//}

int main( int /*argc*/, char ** /*argv*/ )
{
Expand Down
8 changes: 5 additions & 3 deletions tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
add_subdirectory( ArrayProxy )
add_subdirectory( ArrayProxyNoTemporaries )
add_subdirectory( ArrayWrapper )
if( VULKAN_HPP_ENABLE_CPP20_MODULES )
add_subdirectory( Cpp20Modules )
endif()
add_subdirectory( DesignatedInitializers )
add_subdirectory( DeviceFunctions )
add_subdirectory( DispatchLoaderDynamic )
Expand All @@ -31,7 +34,6 @@ add_subdirectory( NoExceptions )
add_subdirectory( StridedArrayProxy )
add_subdirectory( StructureChain )
add_subdirectory( UniqueHandle )
add_subdirectory( UniqueHandleDefaultArguments )
if( VULKAN_HPP_ENABLE_CPP20_MODULES )
add_subdirectory( Cpp20Modules )
if(CMAKE_SIZEOF_VOID_P EQUAL 8)
add_subdirectory( UniqueHandleDefaultArguments )
endif()
10 changes: 10 additions & 0 deletions tests/StridedArrayProxy/StridedArrayProxy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,16 @@
// VulkanHpp Samples : StridedArrayProxy
// Compile test on using vk::StridedArrayProxy

#if defined( _MSC_VER )
// no need to ignore any warnings with MSVC
#elif defined( __clang__ )
# pragma clang diagnostic ignored "-Wunused-variable"
#elif defined( __GNUC__ )
# pragma GCC diagnostic ignored "-Wunused-but-set-variable"
#else
// unknow compiler... just ignore the warnings for yourselves ;)
#endif

#include <iostream>
#include <vulkan/vulkan.hpp>
#if ( 20 <= VULKAN_HPP_CPP_VERSION )
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,18 @@
//
// VulkanHpp Test: Compile only test for issue 467.

// Should be used on 64 bit only, as on 32 bit the test is ambiguous.

#define VULKAN_HPP_NO_EXCEPTIONS
#define VULKAN_HPP_DISPATCH_LOADER_DYNAMIC 1

#include <vulkan/vulkan.hpp>

VULKAN_HPP_DEFAULT_DISPATCH_LOADER_DYNAMIC_STORAGE

#if defined( __x86_64__ ) || defined( _M_X64 )
// On 32-bit systems the test is ambiguous.
int main( int /*argc*/, char ** /*argv*/ )
{
VkSurfaceKHR surface = 0;
auto uniqueSurface = vk::UniqueSurfaceKHR( surface, vk::Instance() );
return 0;
}
#endif

0 comments on commit 3e0d722

Please sign in to comment.