Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vk::Format that matches coloredCubeData in DynamicUniform RAII sample #1729

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

xbohdan
Copy link
Contributor

@xbohdan xbohdan commented Nov 13, 2023

Hi! The samples in this repository are a gem to anyone learning Vulkan.
I stumbled upon a subtle logical error.
The chosen vk::Format in the DynamicUniform RAII sample does not match coloredCubeData, which results in some information about color being discarded.
The corresponding sample from the vk namespace uses the correct format.
Since these code snippets carry educational purpose, we should fix this issue to avoid confusion.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2023

CLA assistant check
All committers have signed the CLA.

@asuessenbach
Copy link
Contributor

Thanks for spotting this issue. And fixing it directly!

@asuessenbach asuessenbach merged commit 1bfaa9f into KhronosGroup:main Nov 16, 2023
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants