Use vk::Format that matches coloredCubeData in DynamicUniform RAII sample #1729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! The samples in this repository are a gem to anyone learning Vulkan.
I stumbled upon a subtle logical error.
The chosen
vk::Format
in the DynamicUniform RAII sample does not matchcoloredCubeData
, which results in some information about color being discarded.The corresponding sample from the
vk
namespace uses the correct format.Since these code snippets carry educational purpose, we should fix this issue to avoid confusion.