-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of noexcept-path for vk::raii classes #1742
Conversation
6fbb733
to
249070f
Compare
I think the failures for clang-13 are because the compiler does not properly support c++23 yet and requires the Other failures with newer versions of clang are because the compiler doesn't support Overwriting VULKAN_HPP_EXPECTED/VULKAN_HPP_UNEXPECTED might not be possible with older c++ standard as template type deducation is not that advanced |
5923659
to
26a50d4
Compare
snippets/macros.hpp
Outdated
@@ -265,3 +266,20 @@ namespace VULKAN_HPP_NAMESPACE | |||
# define VULKAN_HPP_DEFAULT_ARGUMENT_NULLPTR_ASSIGNMENT = nullptr | |||
# define VULKAN_HPP_DEFAULT_DISPATCHER_ASSIGNMENT = VULKAN_HPP_DEFAULT_DISPATCHER | |||
#endif | |||
|
|||
#if !defined( VULKAN_HPP_EXPECTED ) && ( 23 <= VULKAN_HPP_CPP_VERSION ) && ( __has_include( <expected>)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use the feature test macro __cpp_lib_expected
. Clang has <expected>
via GCC, but cannot use the feature due to missing full support for concepts.
26a50d4
to
b184c1b
Compare
b184c1b
to
ea12ce6
Compare
Ah, seems this has been merged. I saw this discussion on Reddit, and one comment in particular seems relevant:
It seems one possible way around this is to either use the passkey idiom, or declare |
Resolves #1498.