Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for libvulkan.1.dylib #1755

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Check for libvulkan.1.dylib #1755

merged 1 commit into from
Jan 2, 2024

Conversation

juan-lunarg
Copy link
Contributor

@juan-lunarg juan-lunarg commented Dec 20, 2023 •
edited
Loading

No description provided.

@juan-lunarg juan-lunarg mentioned this pull request Dec 20, 2023
Merged
richard-lunarg
richard-lunarg approved these changes Dec 20, 2023
View reviewed changes
Copy link

@richard-lunarg richard-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified this fixes the issue I was seeing last interim SDK build.

theHamsta
theHamsta approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@theHamsta theHamsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would agree to this PR since the same logic is used for Linux.

@asuessenbach
Copy link
Contributor

Thanks for spotting this issue and fixing it!

@asuessenbach asuessenbach merged commit d684b72 into KhronosGroup:main Jan 2, 2024
66 checks passed
@juan-lunarg juan-lunarg deleted the juan/apple_1 branch January 3, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-lunarg richard-lunarg richard-lunarg approved these changes

@theHamsta theHamsta theHamsta approved these changes

@asuessenbach asuessenbach Awaiting requested review from asuessenbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juan-lunarg @asuessenbach @theHamsta @richard-lunarg