Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VULKAN_HPP_NO_WIN32_PROTOTYPES preprocessor condition #1756

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Added VULKAN_HPP_NO_WIN32_PROTOTYPES preprocessor condition #1756

merged 2 commits into from
Jan 9, 2024

Conversation

siukosev
Copy link
Contributor

Added VULKAN_HPP_NO_WIN32_PROTOTYPES preprocessor condition which disables dynamic loader win32 types declaration.

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2023

CLA assistant check
All committers have signed the CLA.

@theHamsta
Copy link
Contributor

Related issue #1752

@asuessenbach
Copy link
Contributor

@syukosevn Would you mind to add some words about VULKAN_HPP_NO_WIN32_PROTOTYPES in the Readme.md?

…ables dynamic loader type declaration for win32
@siukosev
Copy link
Contributor Author

siukosev commented Jan 6, 2024

Added description in README

Copy link
Contributor

@asuessenbach asuessenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sorry for being picky... but the configuration defines are listed in alphabetical order here. Would you please move the description of your new define to the appropriate position?

README.md Outdated
@@ -913,6 +913,11 @@ See ```VULKAN_HPP_EXPECTED```.

With this define you can include a reflection mechanism on the vk-structures. It adds a function ```reflect``` that returns a tuple-version of the structure. That tuple then could easily be iterated. But at least for now, that feature takes lots of compile-time resources, so currently it is recommended to enable that feature only if you're willing to pay that price.

#### VULKAN_HPP_NO_WIN32_PROTOTYPES

By default, if ```DYNAMIC_LOADER_TOOL``` is enabled on Win32, ```vulkan.hpp``` declares ```HANDLE```, ```LoadLibraryA```, and other required symbols. It could cause conflicts with the ```Windows.h``` alternatives, such as ```WindowsHModular```.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use the complete term VULKAN_HPP_ENABLE_DYNAMIC_LOADER_TOOL here, instead of just DYNAMIC_LOADER_TOOL.
Also, HANDLE is not declared here, but HINSTANCE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I assume

@asuessenbach asuessenbach merged commit 180ef2f into KhronosGroup:main Jan 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants