Introduce implicit cast operators for vk::UniqueHandles, vk::SharedHandles and vk::raii::Handles #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndles and vk::raii::Handles
asuessenbach
force-pushed
the
implicit_cast
branch
from
45a0718 to
94a4ff3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an implicit cast for the vk::UniqueHandles and the vk::SharedHandles, "hidden" by the define
VULKAN_HPP_SMART_HANDLE_IMPLICIT_CAST. Those two handle wrapper are semantically very close to the corresponding pointer types and thus the implicit cast is not a perfect fit. Making it available by an opt-in seems to be reasonable.The vk::raii::Handles, on the other hand, are more a non-pointer wrapper, and thus get the implicit-cast unconditionally.
Resolves #1731.