Update the instance extensions list for WSI #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theHamsta
reviewed
May 31, 2024
samples/utils/utils.cpp
Outdated
| #elif defined( VK_USE_PLATFORM_MIR_KHR ) | ||
| extensions.push_back( VK_KHR_MIR_SURFACE_EXTENSION_NAME ); | ||
| #elif defined( VK_USE_PLATFORM_METAL_EXT ) | ||
| extensions.push_back( VK_EXT_METAL_SURFACE_EXTENSION_NAME ); |
There was a problem hiding this comment.
could you use spaces like in the rest of the file?
|
@cutieskye Would you mind to rebase your PR to resolve the failing CI on Ubuntu? |
The VK_MVK_ios_surface and VK_MVK_macos_surface extensions have been deprecated by the VK_EXT_metal_surface extension. The VK_KHR_mir_surface extension has been removed from the Vulkan specification and, therefore, should not be used.
|
Thanks a lot for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VK_MVK_ios_surface and VK_MVK_macos_surface extensions have been deprecated by the VK_EXT_metal_surface extension.
The VK_KHR_mir_surface extension has been removed from the Vulkan specification and, therefore, should not be used.