Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the name of two flags in the readme. #2040

Closed
wants to merge 1 commit into from
Closed

Correct the name of two flags in the readme. #2040

wants to merge 1 commit into from

Conversation

asuessenbach
Copy link
Contributor

No description provided.

@M2-TE
Copy link

M2-TE commented Jan 9, 2025 •
edited
Loading

I think you should add VULKAN_HPP_NO_UNION_CONSTRUCTORS to the readme as well. It seems the old flag VULKAN_HPP_NO_CONSTRUCTORS included union constructors and only setting VULKAN_HPP_NO_STRUCT_CONSTRUCTORS breaks designated initializers for unions, at least for vk::ClearValue in my case

The same probably goes for VULKAN_HPP_NO_UNION_SETTERS

@asuessenbach
Copy link
Contributor Author

Ah, I see. Thanks again for that hint.
That is, I'll adjust the source to the documentation, instead :)

@asuessenbach asuessenbach deleted the readme branch January 9, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asuessenbach @M2-TE