Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer: Initialize PhysicalDeviceData members #729

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aqnuep
Copy link
Contributor

@aqnuep aqnuep commented Dec 7, 2024

No description provided.

@aqnuep aqnuep requested a review from ziga-lunarg December 7, 2024 11:24
@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 319155.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 3443 running.

@aqnuep aqnuep marked this pull request as draft December 7, 2024 11:27
@aqnuep aqnuep self-assigned this Dec 7, 2024
@aqnuep aqnuep marked this pull request as ready for review December 7, 2024 11:27
@aqnuep aqnuep marked this pull request as draft December 7, 2024 11:29
@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 3443 passed.

@aqnuep aqnuep force-pushed the aqnuep/initialize-all-pdd-members branch from b39e8b5 to c73a696 Compare December 7, 2024 11:30
@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 319171.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 3444 running.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 3444 passed.

Copy link
Contributor

@ziga-lunarg ziga-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but was this causing issues?

@aqnuep
Copy link
Contributor Author

aqnuep commented Dec 7, 2024

No, nothing that I could find, but as the TSAN tests on the VVL showing all sorts of weird slowdowns recently, I'm trying to find out if any of it actually comes from the profile. No luck so far, but getting rid of uninitialized fields should be a good thing nonetheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants