Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add missing tests #9130

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

ziga-lunarg
Copy link
Contributor

Part of #9119

For
VUID-vkCmdEndQuery-query-00812
VUID-vkCmdEndQuery-queryPool-03228
VUID-vkCmdExecuteCommands-None-02286

I don't see a way to hit these VUIDs without hitting something else first.

And VUID-vkCmdExecuteCommands-pCommandBuffers-00091 runs into an unassigned that seems to check the same thing.

TEST_F(NegativeSecondaryCommandBuffer, MissingSimultaniousUseBit) {
    RETURN_IF_SKIP(Init());

    vkt::CommandBuffer primary(*m_device, m_command_pool);
    vkt::CommandBuffer secondary(*m_device, m_command_pool, VK_COMMAND_BUFFER_LEVEL_SECONDARY);
    secondary.Begin();
    secondary.End();

    primary.Begin(VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT);
    vk::CmdExecuteCommands(primary.handle(), 1u, &secondary.handle());
    primary.End();

    m_command_buffer.Begin(VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT);
    vk::CmdExecuteCommands(m_command_buffer.handle(), 1u, &secondary.handle());
    m_command_buffer.End();

    m_default_queue->Submit(primary);
    m_errorMonitor->SetDesiredError("VUID-vkCmdExecuteCommands-pCommandBuffers-00091");
    m_default_queue->Submit(m_command_buffer);
    m_errorMonitor->VerifyFound();
    m_default_queue->Wait();
}

@ziga-lunarg ziga-lunarg requested a review from a team as a code owner January 4, 2025 12:31
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 336857.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 336872.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18504 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18504 passed.

@spencer-lunarg spencer-lunarg merged commit 4acb4c4 into KhronosGroup:main Jan 4, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants