Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layers: Improve profile error messages #9203

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spencer-lunarg
Copy link
Contributor

This an attempt at #8625

@aqnuep I agree with Mike that just saying IsImageCompatibleWithVideoSession failed doesn't help the user narrow things down. I was going to try and add some more helper to print things out (without wasting cycles when things are valid) but realize I don't know enough about Video to know what information would be helpful, so making this PR in hope you can come up with something similar to solve the issue

A new error message now looks like

Validation Error: [ VUID-VkVideoBeginCodingInfoKHR-pPictureResource-07240 ] ... 
vkCmdBeginVideoCodingKHR(): pBeginInfo->pReferenceSlots[0].pPictureResource->imageViewBinding (VkImageView 0xd10d270000000018[] created from VkImage 0xd897d90000000016[]) is not compatible with the video profile VkVideoSessionKHR 0xe7f79a0000000005[] was created with.
The image was create without VK_IMAGE_CREATE_VIDEO_PROFILE_INDEPENDENT_BIT_KHR and could not find an profile for the image supported with the profile:
videoCodecOperation = VK_VIDEO_CODEC_OPERATION_ENCODE_AV1_BIT_KHR
chromaSubsampling = VK_VIDEO_CHROMA_SUBSAMPLING_422_BIT_KHR
lumaBitDepth = VK_VIDEO_COMPONENT_BIT_DEPTH_8_BIT_KHR
chromaBitDepth = VK_VIDEO_COMPONENT_BIT_DEPTH_8_BIT_KHR
VkVideoEncodeUsageInfoKHR::videoUsageHints = VkVideoEncodeUsageFlagsKHR(0)
VkVideoEncodeUsageInfoKHR::videoContentHints = VkVideoEncodeContentFlagsKHR(0)
VkVideoEncodeUsageInfoKHR::tuningMode = VK_VIDEO_ENCODE_TUNING_MODE_DEFAULT_KHR

(Note, we had this same issue with showing why two pipeline layers were not compatible, see DescribePipelineLayoutSetNonCompatible)

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner January 10, 2025 19:36
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 342446.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18611 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 18611 passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants