refactor(build script): rewrite the main build script #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of annoying file reading/writing logics Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
force-pushed
the
cache-invalidation-fix
branch
from
3575651 to
5f4d0f6
Compare
Signed-off-by: onur-ozkan <[email protected]>
onur-ozkan
commented
Jan 13, 2025
There was a problem hiding this comment.
We need to revise our docs... This is extremely outdated.
onur-ozkan
commented
Jan 13, 2025
There was a problem hiding this comment.
Since this is re-written from scratch, I suggest you to review this by opening the file directly as the diff view will make it likely impossible to understand the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous build script were highly unstable and relied on the
MM_DATETIMEandMM_VERSIONfiles which was very annoying. These files caused cargo to invalidate the build cache, so even if you rancargo buildmultiple times without changing anything, it would still rebuild because the build script triggered cache invalidation.This PR makes the build script straightforward and more stable without causing cache invalidation. The final versioning output remains as is, but the implementation side is robust than ever.
Major effects:
MM_VERSIONandMM_DATETIMEfiles are no longer needed in the project root.MM_DATETIMEfile could become outdated as it wasn't consistently updated.