HD Address Management & Seed Import

[naezith]

Replaced with comment by @CharlVS. See the comment version history for the original version.

HD Address Management & Seed Import

This PR is the first milestone for HD wallet integration, focusing on HD seed import and address generation. The remaining integration PRs will follow soon.

QA:

Please test the following functionality:

1. Seed import and export (HD and non-HD with bip39 and non-bip39 seed)
2. Switching between HD and non-HD mode
3. Address generation: Multiple addresses are allowed in HD mode and disabled in non-HD mode. Check that re-importing the seed yields the same addresses.

For Devs:

This also adds WalletType.hdwallet; please review the implementation. It's not listed in the connect list like other WalletType entries so there's some custom code around that.

Please test deeply.

General

Screenshots of seed import:

Screenshots of address management:

MIA

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Visit the preview URL for this PR (updated for commit 26de7f2):

https://walletrc--pull-2510-merge-lzsdoti4.web.app

_{(expires Tue, 21 Jan 2025 15:34:40 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

[smk762]

• confirmed non-BIP39 seed import from file rejected if HD mode selected, or I understand not input.
• confirm no regression when attempting wallet import with same as existing name
• confirm import of 24 word seed via input in HD mode functions as expected.
• Error seen in tx history panel something went wrong when zero balance. Once funded, functioning as expected.
• Error seen when clicking on wallet>receive button
  
• HD addresses list shows balances, but combined balance still zero
  
• KMD rewards claim button leads to endless spinner and error in console logs
  
• Address creation and "hide addresses with zero balance" functioning as expected.

Other errors seen in console logs:

[ShantanuSharma9873]

Tested the PR, and here are my observations from the smoke testing:

• Successfully created a new wallet in both modes: With HD Wallet and Without HD Wallet.
• Successfully saved the seed phrase and downloaded the seed file.

Non-HD Wallet Mode:

• The "Create Address" button was disabled.
• Hovering over the button displayed the tooltip: "Current wallet mode does not support multiple addresses."

HD Wallet Mode:

• Successfully created multiple addresses for a single coin.
• Verified that the addresses could be copied and their QR codes were accessible.

Additional Observations:
Wallet Name Missing:

• In 2/5 cases, the wallet name was not visible at the top right corner, causing the logout button to disappear.
• Had to log out via the Settings tab as a workaround.
  Video:
  https://github.com/user-attachments/assets/f6d92e94-d09e-4b05-88d6-f2388f425e08

Seed File Import Issue:

• When uploading the seed file via the "Import Wallet" option, the message "Wallet name exists" was displayed.
• The seed file being uploaded was the same one downloaded via the "Download Seed File" option in the Settings tab.
  Video:
  https://github.com/user-attachments/assets/980d5595-57ad-4e83-8d4c-45049b384710

The testing is still left to be completed.