7주차 미션 / 서버 3조 김윤서 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JangIkhwan
reviewed
Nov 25, 2024
Comment on lines
+79
to
+82
| Object value = session.getAttribute(USER_SESSION_KEY); | ||
|
|
||
| if (user != null && value != null) { | ||
| if (user.isSameUser((User) value)) { |
There was a problem hiding this comment.
isSameUser()에서 value를 User로 형변환하는 것보다는, value에 session의 값을 할당할 때 형변환하는게 다른 사람이 코드를 이해하는데 도움이 될 것 같아요!
Comment on lines
+84
to
+86
| Question question = questionRepository.findByQuestionId(questionId); | ||
| question.increaseCountOfAnswer(); | ||
|
|
There was a problem hiding this comment.
여기에도 updateCountOfAnswer()가 있어야 하지 않나요?
| User user = new User(userId, password, name, email); | ||
| userRepository.insert(user); | ||
| return "redirect:/"; | ||
| } |
There was a problem hiding this comment.
userId가 일치하는 회원이 존재하는지 확인하는 코드를 추가하면 좋을 것 같아요. 실제 서비스에서는 동일한 id를 갖는 회원이 존재하면 안되니까요.
Comment on lines
+116
to
+121
| log.info("updateQuestion"); | ||
| Question question = questionRepository.findByQuestionId(questionId); | ||
| question.updateTitleAndContents(title, contents); | ||
| questionRepository.update(question); | ||
|
|
||
| return "redirect:/"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.