7주차 미션 / 서버 3조 이윤희 #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JangIkhwan
reviewed
Nov 25, 2024
| @RequestParam String name, | ||
| @RequestParam String email | ||
| ){ | ||
| User user = new User(userId, password, name, email); |
There was a problem hiding this comment.
userId가 일치하는 회원이 존재하는지 확인하는 절차가 추가하면 좋을 것 같아요. 실제 서비스에서는 동일한 id를 갖는 회원이 존재하면 안되니까요.
Comment on lines
+83
to
+85
| if (UserSessionUtils.isLoggedIn(session)) { | ||
| User sessionUser = (User) session.getAttribute(USER_SESSION_KEY); | ||
| if (sessionUser != null && sessionUser.getUserId().equals(userId)) { |
There was a problem hiding this comment.
83번 줄에서 UserSessionUtils의 isLoggedIn()으로 로그인되어 있는지 여부를 확인했기 때문에 여기서 인가가 끝납니다. 그래서 이후에 조건식 2줄은 중복되는 내용이라 없어도 될 것 같네요!
Comment on lines
+88
to
+91
| if (user != null) { | ||
| model.addAttribute("user", user); | ||
| return "user/updateForm"; | ||
| } |
There was a problem hiding this comment.
정말 예외적인 상황이지만 repository로 조회해보니 user가 삭제되어서 없을 수도 있을 것 같네요. 만약 user가 존재하지 않아서 null이라면, 이 코드상으로는 /user/list로 redirect하는데 실제 서비스에서는 어떻게 동작하는 게 좋을지 고민해보는 것도 좋을 것 같아요
Comment on lines
+109
to
+112
| User modifiedUser = new User(userId, password, name, email); | ||
| userRepository.update(modifiedUser); | ||
| log.info("updateUserV1 done"); | ||
| return "redirect:/user/list"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.