7주차 미션 / 서버 1조 강희진 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyouxsun
reviewed
Nov 18, 2024
| // public HomeController(QuestionRepository questionRepository) { | ||
| // this.questionRepository = questionRepository; | ||
| // } | ||
|
|
||
| /** | ||
| * TODO: showHome |
There was a problem hiding this comment.
기능을 모두 구현한 후에 TODO 주석은 지우는 것이 좋습니다:)
| return mav.addObject("users", userRepository.findAll()); | ||
| } | ||
| return new ModelAndView("redirect:/user/loginForm"); | ||
| //리다이렉트를 모델앤뷰로..?? |
There was a problem hiding this comment.
ModelAndView를 통해 리다이렉트 하는 것도 가능하지만,
반환값을 String 타입으로 변경하고 파라미터로 Model을 추가한 후에,
- 로그인 되어있는 사용자인 경우 model에 값을 담아서 "/user/list" 뷰 이름을 반환하고,
- 로그인 되어있지 않은 경우 "redirect:/user/loginForm" 로 리다이렉트하는 것이 더 자연스러울 것 같습니다!
| /** | ||
| * TODO: showQuestionForm | ||
| */ | ||
| @GetMapping("/form") | ||
| public ModelAndView showQuestionForm(HttpServletRequest request){ |
There was a problem hiding this comment.
model에 담을 데이터가 없는 경우에는 String으로 뷰 이름만 반환하는게 더 좋을 것 같아요:)
|
|
||
| question.setCountOfAnswer(0); | ||
| questionRepository.insert(question); | ||
| log.info(String.valueOf(question)); |
There was a problem hiding this comment.
String.valueOf(question) 보다는 question.toString()을 사용하는 것이 더 직관적입니다
| questionRepository.insert(question); | ||
| log.info(String.valueOf(question)); | ||
|
|
||
| System.out.println("saved question id= " + question.getQuestionId()); |
There was a problem hiding this comment.
표준 출력과 로그에 대해서도 공부하시면 좋을 것 같아요!
(둘의 차이점, 왜 로그 사용을 지향해야 하는지 등등)
| } | ||
|
|
||
| Question question = questionRepository.findByQuestionId(Integer.parseInt(questionId)); | ||
| if (!question.isSameUser(loggedInUser)) { |
There was a problem hiding this comment.
기존 코드를 잘 활용해서 구현하셨네요!👍🏻👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코드리뷰 부탁드립니당 🥰🤗