7주차 미션 / 서버 3조 김나은 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JangIkhwan
reviewed
Nov 25, 2024
Comment on lines
+48
to
+53
| log.info("createQuestionV1"); | ||
|
|
||
| Question question = new Question(writer, title, contents, 0); | ||
| questionRepository.insert(question); | ||
|
|
||
| return "redirect:/"; |
There was a problem hiding this comment.
여기에 로그인이 되어 있는지 확인하는 인가 처리가 추가되면 좋을 것 같아요. 실제 서비스에서는 post api마다 해당 사용자가 요청을 수행할 자격이 있는지 확인하는 인가 처리가 필요해요. 이미 form을 받을 때 확인했는데 또 확인할 필요가 있나 싶을 수 있지만 안전한 서버를 만드려면 최소한의 확인은 필요해요
Comment on lines
+43
to
+46
| log.info("createUserV1"); | ||
| User createdUser = new User(userId, password, name, email); | ||
| userRepository.insert(createdUser); | ||
| return "redirect:/user/list"; |
There was a problem hiding this comment.
userId가 일치하는 회원이 존재하는지 확인하는 절차가 추가하면 좋을 것 같아요. 실제 서비스에서는 동일한 id를 갖는 회원이 존재하면 안되니까요.
Comment on lines
+96
to
+104
| public String updateUserV1(@RequestParam("userId") String userId, | ||
| @RequestParam("password") String password, | ||
| @RequestParam("name") String name, | ||
| @RequestParam("email") String email) { | ||
| log.info("updateUserV1"); | ||
| User updatedUser = new User(userId, password, name, email); | ||
| userRepository.update(updatedUser); | ||
| return "redirect:/user/list"; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.