Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expected data in integration tests #3990

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Update expected data in integration tests #3990

merged 2 commits into from
Jan 15, 2025

Conversation

vmishenev
Copy link
Contributor

No description provided.

@vmishenev vmishenev requested a review from adam-enko January 10, 2025 19:52
adam-enko
adam-enko approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@adam-enko adam-enko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the tests are passing, so I'll approve. But how did they get out of sync?

I added these tests quickly, so maybe we can take some time to improve them.

@vmishenev
Copy link
Contributor Author

But how did they get out of sync?

Because of the default footer message includes the current year.

I added these tests quickly, so maybe we can take some time to improve them.

We can change footerMessage in the tests.

@vmishenev vmishenev requested a review from whyoleg January 15, 2025 13:22
@vmishenev vmishenev merged commit d54787b into master Jan 15, 2025
14 checks passed
@vmishenev vmishenev deleted the vmishenev/update-expected-data-in-it branch January 15, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-enko adam-enko adam-enko approved these changes

@whyoleg whyoleg whyoleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmishenev @whyoleg @adam-enko