-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and clean up build scripts #423
base: master
Are you sure you want to change the base?
Changes from all commits
90dcbfb
fd315d9
e2c0d4e
90aa6b6
5898535
94fce17
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
/.idea/* | ||
!/.idea/copyright | ||
.gradle | ||
.kotlin | ||
*.iml | ||
target | ||
build | ||
/local.properties | ||
local.properties | ||
benchmarks.jar |
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -1,34 +1,31 @@ | ||||||||
/* | ||||||||
* Copyright 2019-2023 JetBrains s.r.o. and contributors. | ||||||||
* Use of this source code is governed by the Apache 2.0 License that can be found in the LICENSE.txt file. | ||||||||
*/ | ||||||||
import org.jetbrains.kotlin.gradle.tasks.KotlinCompilationTask | ||||||||
|
||||||||
plugins { | ||||||||
id("kotlin") | ||||||||
id("me.champeau.jmh") | ||||||||
with(libs.plugins) { | ||||||||
alias(kotlin.jvm) | ||||||||
alias(jmh) | ||||||||
} | ||||||||
} | ||||||||
|
||||||||
|
||||||||
val mainJavaToolchainVersion by ext(project.property("java.mainToolchainVersion")) | ||||||||
val modularJavaToolchainVersion by ext(project.property("java.modularToolchainVersion")) | ||||||||
|
||||||||
sourceSets { | ||||||||
dependencies { | ||||||||
implementation(project(":kotlinx-datetime")) | ||||||||
implementation("org.openjdk.jmh:jmh-core:1.35") | ||||||||
implementation(libs.jmh) | ||||||||
} | ||||||||
} | ||||||||
|
||||||||
// Publish benchmarks to the root for the easier 'java -jar benchmarks.jar` | ||||||||
// publish benchmarks to the repository root for easier `java -jar benchmarks.jar` | ||||||||
tasks.named<Jar>("jmhJar") { | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
val nullString: String? = null | ||||||||
archiveBaseName.set("benchmarks") | ||||||||
archiveClassifier.set(nullString) | ||||||||
archiveVersion.set(nullString) | ||||||||
archiveVersion.convention(nullString) | ||||||||
destinationDirectory.set(file("$rootDir")) | ||||||||
archiveBaseName = "benchmarks" | ||||||||
archiveClassifier = null | ||||||||
archiveVersion.convention(null as String?) | ||||||||
archiveVersion = null | ||||||||
destinationDirectory = file("$rootDir") | ||||||||
} | ||||||||
|
||||||||
repositories { | ||||||||
mavenCentral() | ||||||||
// compile all Kotlin code from the module during full-repository builds | ||||||||
tasks.named("assemble") { | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
tasks.withType<KotlinCompilationTask<*>>().forEach { compileKotlinTask -> | ||||||||
dependsOn(compileKotlinTask) | ||||||||
Comment on lines
+28
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
} | ||||||||
} |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer not using
with
to keep things as simple as possible inplugins
.