Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video channel fix #545

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Video channel fix #545

merged 1 commit into from
Apr 23, 2022

Conversation

lpenguin
Copy link
Contributor

@lpenguin lpenguin commented Feb 2, 2022

Fixes #539

@lpenguin lpenguin mentioned this pull request Feb 2, 2022
Closed
@lpenguin lpenguin marked this pull request as ready for review February 2, 2022 08:25
@lpenguin lpenguin requested a review from stalkerg February 2, 2022 08:26
@lpenguin
Copy link
Contributor Author

lpenguin commented Feb 2, 2022

@caiiiycuk You've mentioned in #539 that you did similar changes in your web branch - should this go to the master branch then?

@caiiiycuk
Copy link
Contributor

@caiiiycuk You've mentioned in #539 that you did similar changes in your web branch - should this go to the master branch then?

Yes. because in web branch ffmpeg is not used, instead of it I am using APNG files, so this is differed code bases.

@lpenguin lpenguin marked this pull request as draft February 2, 2022 15:07
@lpenguin lpenguin marked this pull request as ready for review February 3, 2022 09:38
stalkerg
stalkerg approved these changes Mar 13, 2022
View reviewed changes
Copy link
Contributor

@stalkerg stalkerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine.

@stalkerg
Copy link
Contributor

stalkerg commented Apr 3, 2022

@lpenguin can you merge it?

@lpenguin lpenguin merged commit ee99044 into KranX:renderer-ng Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stalkerg stalkerg stalkerg approved these changes

@caiiiycuk caiiiycuk caiiiycuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Renderer of Next Generation
Development

Successfully merging this pull request may close these issues.
3 participants
@lpenguin @caiiiycuk @stalkerg