Make fzf search available from other repl modes #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moelf
approved these changes
Nov 27, 2023
Moelf
reviewed
Nov 19, 2024
| @@ -288,6 +288,15 @@ function insert_keybindings(repl = Base.active_repl) | |||
| end | |||
|
|
|||
| main_mode.keymap_dict = LineEdit.keymap(Dict{Any, Any}[NEW_KEYBINDINGS, main_mode.keymap_dict]) | |||
|
|
|||
| # Inject ^R keybinding into other repl modes for fzf reverse search to work | |||
| for repl_mode in mirepl.interface.modes[2:end] | |||
There was a problem hiding this comment.
I'm a bit worried this is too intrusive, ideally we only want this to work on Pkg and Shell mode right? not, say, R-mode or the now-gone C++ mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds fzf reverse search when in the
help,pkg, andshellrepl modes to address #318