Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔎 [M-02] fulfillOracleQuery #24

Merged

Conversation

JaredBorders
Copy link
Contributor

@JaredBorders JaredBorders commented Dec 4, 2023

Response to External Guhu Audit

Audit: https://gist.github.com/guhu95/d1214b942ef0dfd5672f3a3167a231d1

On-going Response: https://gist.github.com/JaredBorders/5611450065734074ee6a7add8332df7b

Issues Remedied

[M-02] fulfillOracleQuery with Non-Zero ETH Value Will Revert or Trap ETH

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (97ced46) 74.10% compared to head (a1b475c) 63.25%.
Report is 1 commits behind head on Remove-Trusted-Multicall-Forwarder.

Files Patch % Lines
src/libraries/SignatureCheckerLib.sol 0.00% 28 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                           @@
##           Remove-Trusted-Multicall-Forwarder      #24       +/-   ##
=======================================================================
- Coverage                               74.10%   63.25%   -10.85%     
=======================================================================
  Files                                       5        6        +1     
  Lines                                     139      166       +27     
  Branches                                   29       35        +6     
=======================================================================
+ Hits                                      103      105        +2     
- Misses                                     30       55       +25     
  Partials                                    6        6               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaredBorders JaredBorders changed the title [M-02] ☂️ [M-02] Dec 5, 2023
@JaredBorders JaredBorders changed the title ☂️ [M-02] 🔎 [M-02] fulfillOracleQuery Dec 6, 2023
@JaredBorders JaredBorders merged commit ee7b210 into Remove-Trusted-Multicall-Forwarder Dec 10, 2023
4 of 6 checks passed
@JaredBorders JaredBorders deleted the M-02-fulfillOracleQuery-Fix branch January 5, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants