generated from Kwenta/foundry-scaffold
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔎 [M-02] fulfillOracleQuery #24
Merged
JaredBorders
merged 34 commits into
Remove-Trusted-Multicall-Forwarder
from
M-02-fulfillOracleQuery-Fix
Dec 10, 2023
Merged
🔎 [M-02] fulfillOracleQuery #24
JaredBorders
merged 34 commits into
Remove-Trusted-Multicall-Forwarder
from
M-02-fulfillOracleQuery-Fix
Dec 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## Remove-Trusted-Multicall-Forwarder #24 +/- ##
=======================================================================
- Coverage 74.10% 63.25% -10.85%
=======================================================================
Files 5 6 +1
Lines 139 166 +27
Branches 29 35 +6
=======================================================================
+ Hits 103 105 +2
- Misses 30 55 +25
Partials 6 6 ☔ View full report in Codecov by Sentry. |
jcmonte
approved these changes
Dec 8, 2023
JaredBorders
merged commit Dec 10, 2023
ee7b210
into
Remove-Trusted-Multicall-Forwarder
4 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to External Guhu Audit
Audit: https://gist.github.com/guhu95/d1214b942ef0dfd5672f3a3167a231d1
On-going Response: https://gist.github.com/JaredBorders/5611450065734074ee6a7add8332df7b
Issues Remedied
[M-02] fulfillOracleQuery with Non-Zero ETH Value Will Revert or Trap ETH