🔎 [N-08] Unnecessary Cast #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcmonte
approved these changes
Dec 6, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## N-04-Docs #29 +/- ##
=============================================
+ Coverage 62.13% 63.25% +1.12%
=============================================
Files 6 6
Lines 169 166 -3
Branches 36 35 -1
=============================================
Hits 105 105
+ Misses 58 55 -3
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to External Guhu Audit
Audit: https://gist.github.com/guhu95/d1214b942ef0dfd5672f3a3167a231d1
On-going Response: https://gist.github.com/JaredBorders/5611450065734074ee6a7add8332df7b
Issues Remedied
[N-08] Unnecessary Casting Post Bit Shift