Code

🏅 Guhu Audit Response#31

Code

Merged

JaredBorders merged 105 commits intomainKwenta/smart-margin-v3:mainfrom add-batchingKwenta/smart-margin-v3:add-batchingCopy head branch name to clipboardDec 19, 2023

+1,954-2,879

Commits

Commits on Dec 4, 2023

• 🗑️ Remove git module

  JaredBorders

  committed
  b78ab49

  Copy full SHA for b78ab49

• 🗑️ Remove Trusted Multicall Forwarder

  JaredBorders

  committed
  4b89315

  Copy full SHA for 4b89315

• 👷🏻‍♂️ Update Engine to not rely on ERC2771Context

  JaredBorders

  committed
  f83f7a2

  Copy full SHA for f83f7a2

• ✅ Update mocks

  JaredBorders

  committed
  9f9e547

  Copy full SHA for 9f9e547

• ✅ Update tests

  JaredBorders

  committed
  aa17a45

  Copy full SHA for aa17a45

• 🚀 Update deployment logic/records

  JaredBorders

  committed
  bccbbea

  Copy full SHA for bccbbea

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  727df06

  Copy full SHA for 727df06

• 📚 Update README

  JaredBorders

  committed
  97ced46

  Copy full SHA for 97ced46

• ✅ Update hh test

  JaredBorders

  committed
  2b3b780

  Copy full SHA for 2b3b780

• 📚 Update docs

  JaredBorders

  committed
  c4f6614

  Copy full SHA for c4f6614

• ✅ Improve tests

  JaredBorders

  committed
  dca5f4c

  Copy full SHA for dca5f4c

• ✨ Prettify

  JaredBorders

  committed
  3b2f1a1

  Copy full SHA for 3b2f1a1

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  2e1e974

  Copy full SHA for 2e1e974

• 📚 Update natspec

  JaredBorders

  committed
  ae5c23d

  Copy full SHA for ae5c23d

Commits on Dec 5, 2023

• 👷🏻‍♂️ Add check for reduce-only co specifying zero size delta to prevent griefing

  JaredBorders

  committed
  e3c0de5

  Copy full SHA for e3c0de5

• ✅ Add test for zero size delta reduce-only co

  JaredBorders

  committed
  f9dec95

  Copy full SHA for f9dec95

• 👷🏻‍♂️ Replace Solady with OZ ECDSA Library

  JaredBorders

  committed
  7440b62

  Copy full SHA for 7440b62

• 👷🏻‍♂️ Update sig verification logic

  JaredBorders

  committed
  309139c

  Copy full SHA for 309139c

• 🗑️ Remove unused code

  JaredBorders

  committed
  771c3ce

  Copy full SHA for 771c3ce

• 📚 Improve docs

  JaredBorders

  committed
  ed856a5

  Copy full SHA for ed856a5

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  721171a

  Copy full SHA for 721171a

• ✂️ Trim IPyth

  JaredBorders

  committed
  7aec488

  Copy full SHA for 7aec488

• ✂️ Trim IERC7412

  JaredBorders

  committed
  d811436

  Copy full SHA for d811436

• ✂️ Trim IPerpsMarketProxy

  JaredBorders

  committed
  32d3793

  Copy full SHA for 32d3793

• ✅ Add interface to tests

  JaredBorders

  committed
  543a34c

  Copy full SHA for 543a34c

• ✨ Prettify

  JaredBorders

  committed
  3ecb7bc

  Copy full SHA for 3ecb7bc

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  272e30d

  Copy full SHA for 272e30d

• 👷🏻‍♂️ Add logic check to authentication

  JaredBorders

  committed
  c40d38c

  Copy full SHA for c40d38c

• ✅ Test new logic

  JaredBorders

  committed
  cacc5a3

  Copy full SHA for cacc5a3

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  a175ec7

  Copy full SHA for a175ec7

Commits on Dec 6, 2023

• 📚 Updates docs

  JaredBorders

  committed
  23bb0a3

  Copy full SHA for 23bb0a3

• 🗑️ Remove cast

  JaredBorders

  committed
  85f744b

  Copy full SHA for 85f744b

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  d96e51c

  Copy full SHA for d96e51c

• 🗑️ Remove lib function

  JaredBorders

  committed
  e1ad372

  Copy full SHA for e1ad372

• 🗑️ Remove test

  JaredBorders

  committed
  c28c24b

  Copy full SHA for c28c24b

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  d58bba2

  Copy full SHA for d58bba2

• 🗑️ Remove comment

  JaredBorders

  committed
  a3e2286

  Copy full SHA for a3e2286

• 👷🏻‍♂️ Create forwarder

  JaredBorders

  committed
  3fe7212

  Copy full SHA for 3fe7212

• ⛳️ Increment unchecked

  JaredBorders

  committed
  eca5915

  Copy full SHA for eca5915

Commits on Dec 7, 2023

• forge install: openzeppelin-contracts

  Show description for c38ba08
  JaredBorders

  committed
  c38ba08

  Copy full SHA for c38ba08

• ✂️ Significantly trim trusted forwarder

  JaredBorders

  committed
  9dd6a36

  Copy full SHA for 9dd6a36

• ✨ Prettify

  JaredBorders

  committed
  6607d3d

  Copy full SHA for 6607d3d

• 👷🏻‍♂️ Draft Minimal Trusted Forwarder

  JaredBorders

  committed
  a5acf7d

  Copy full SHA for a5acf7d

• 👷🏻‍♂️ Update Engine to deploy TrustedForwarder

  JaredBorders

  committed
  1919292

  Copy full SHA for 1919292

• ✅ Test skeleton commit

  JaredBorders

  committed
  70041fc

  Copy full SHA for 70041fc

• 👷🏻‍♂️ Refactor Trusted Forwarder

  JaredBorders

  committed
  e811876

  Copy full SHA for e811876

• ✅ Test TrustedForwarder.aggregate()

  JaredBorders

  committed
  6020f4e

  Copy full SHA for 6020f4e

Commits on Dec 8, 2023

• 🗑️ Remove duplicate tests

  JaredBorders

  committed
  e2704e4

  Copy full SHA for e2704e4

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  98aac57

  Copy full SHA for 98aac57

• 📚 Update README

  JaredBorders

  committed
  8ed0504

  Copy full SHA for 8ed0504

Commits on Dec 11, 2023

• 👷🏻‍♂️ Update co price condition checks

  JaredBorders

  committed
  ed767bf

  Copy full SHA for ed767bf

• 👷🏻‍♂️ Update engine interface to reflect logic changes

  JaredBorders

  committed
  340353a

  Copy full SHA for 340353a

Commits on Dec 12, 2023

• 🗑️ Remove function

  JaredBorders

  committed
  e9dc3e8

  Copy full SHA for e9dc3e8

• 📚 Update README

  JaredBorders

  committed
  4c6a525

  Copy full SHA for 4c6a525

• 👷🏻‍♂️ Update co price condition checks

  JaredBorders

  committed
  b06eda0

  Copy full SHA for b06eda0

• 🚀 Update deployment scripts

  JaredBorders

  committed
  83879bf

  Copy full SHA for 83879bf

• ✅ Update Bootstrap & constants

  JaredBorders

  committed
  15f8bdc

  Copy full SHA for 15f8bdc

• ✅ Update Mocks, Utils, etc

  JaredBorders

  committed
  a17797a

  Copy full SHA for a17797a

• ✅ Update forge tests

  JaredBorders

  committed
  4393ea0

  Copy full SHA for 4393ea0

• ✅ Update hardhat test

  JaredBorders

  committed
  efbbb20

  Copy full SHA for efbbb20

• ⚙️ Add npm script

  JaredBorders

  committed
  890ca55

  Copy full SHA for 890ca55

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  688be49

  Copy full SHA for 688be49

• ✅ Add test

  JaredBorders

  committed
  4ae03e8

  Copy full SHA for 4ae03e8

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  8837d58

  Copy full SHA for 8837d58

• ✅ Add test

  JaredBorders

  committed
  f3fddf9

  Copy full SHA for f3fddf9

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  b7391e3

  Copy full SHA for b7391e3

• ✅ Add test

  JaredBorders

  committed
  539cf3c

  Copy full SHA for 539cf3c

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  99ba169

  Copy full SHA for 99ba169

Commits on Dec 14, 2023

• 📚 Update docs

  JaredBorders

  committed
  a4296da

  Copy full SHA for a4296da

• 🔮 Remove Pyth Oracle Query

  JaredBorders

  authored
  2227ddb

  Copy full SHA for 2227ddb

• ⛳️ Optimize condition selector check

  JaredBorders

  committed
  258297d

  Copy full SHA for 258297d

• 👷🏻‍♂️ Denominate co fee is sUSD

  JaredBorders

  committed
  bd323c3

  Copy full SHA for bd323c3

• 🗑️ oz

  JaredBorders

  committed
  c5f53b9

  Copy full SHA for c5f53b9

• 👷🏻‍♂️ Update constants and remove unused contracts

  JaredBorders

  committed
  8c8ce77

  Copy full SHA for 8c8ce77

Commits on Dec 15, 2023

• 👷🏻‍♂️ Make Engine Multicallable

  JaredBorders

  committed
  24fb67c

  Copy full SHA for 24fb67c

• ✅ Test multicallable and ensure no double spend

  JaredBorders

  committed
  6e9233e

  Copy full SHA for 6e9233e

• ✅ Update tests

  JaredBorders

  committed
  f283189

  Copy full SHA for f283189

• ✅ Credit test bones

  JaredBorders

  committed
  a3e1c6e

  Copy full SHA for a3e1c6e

• 📚 Update README

  JaredBorders

  committed
  4fc8dad

  Copy full SHA for 4fc8dad

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  1e6141a

  Copy full SHA for 1e6141a

• 📚 Update natspec

  JaredBorders

  committed
  10c11a6

  Copy full SHA for 10c11a6

• ✅ Refactor test

  JaredBorders

  committed
  3654c30

  Copy full SHA for 3654c30

• ✅ Add failing tests

  JaredBorders

  committed
  f5b27d6

  Copy full SHA for f5b27d6

• 👷🏻‍♂️ Rename error

  JaredBorders

  committed
  242daa1

  Copy full SHA for 242daa1

• ✅ Test credit management

  JaredBorders

  committed
  d69ab93

  Copy full SHA for d69ab93

• 📚 Rename section

  JaredBorders

  committed
  7933cdc

  Copy full SHA for 7933cdc

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  e706285

  Copy full SHA for e706285

• 📚 Update system docs

  JaredBorders

  committed
  42cac7b

  Copy full SHA for 42cac7b

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  541d205

  Copy full SHA for 541d205

• ✨ Prettify

  JaredBorders

  committed
  7439c41

  Copy full SHA for 7439c41

Commits on Dec 18, 2023

• 🗑️ Remove unused code

  JaredBorders

  committed
  0ccb149

  Copy full SHA for 0ccb149

• 📚 Add Solady author

  JaredBorders

  committed
  7a4ecc3

  Copy full SHA for 7a4ecc3

• 👷🏻‍♂️ Update EIP-712

  JaredBorders

  committed
  0b0ffe4

  Copy full SHA for 0b0ffe4

• 👷🏻‍♂️ Revert when invalid reduce only co

  JaredBorders

  committed
  afc292b

  Copy full SHA for afc292b

• ✅ Update tests for reduce only co's

  JaredBorders

  committed
  338b018

  Copy full SHA for 338b018

• 🗑️ Remove custom errors

  JaredBorders

  committed
  eba862a

  Copy full SHA for eba862a

• 👷🏻‍♂️ Rename deposit/withdraw to credit/debit

  JaredBorders

  committed
  d7a10d5

  Copy full SHA for d7a10d5

• ✅ Update credit tests

  JaredBorders

  committed
  84dd922

  Copy full SHA for 84dd922

• 📚 Fix typo

  JaredBorders

  committed
  657c52a

  Copy full SHA for 657c52a

• 👷🏻‍♂️ Rename multicallable for clarity

  JaredBorders

  committed
  d7d9458

  Copy full SHA for d7d9458

• ✅ Update multicallable tests

  JaredBorders

  committed
  4346deb

  Copy full SHA for 4346deb

Commits on Dec 19, 2023

• 👷🏻‍♂️ Add size to price conditions

  JaredBorders

  committed
  48a86a2

  Copy full SHA for 48a86a2

• ✅ Update tests

  JaredBorders

  committed
  af0d04b

  Copy full SHA for af0d04b

• 👷🏻‍♂️ CEI change

  JaredBorders

  committed
  4d8ca68

  Copy full SHA for 4d8ca68

• 📸 Update gas-snapshot/lcov

  JaredBorders

  committed
  59a2bd5

  Copy full SHA for 59a2bd5