Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷🏻‍♂️ Make Engine Upgradable #36

Merged
merged 15 commits into from
Dec 20, 2023
Merged

👷🏻‍♂️ Make Engine Upgradable #36

merged 15 commits into from
Dec 20, 2023

Conversation

JaredBorders
Copy link
Contributor

@JaredBorders JaredBorders commented Dec 20, 2023 •
edited
Loading

Make Engine Upgradable via OZ UUPS

Description

  • Add OZ in lib
  • Use UUPS contract in Engine
  • Test Upgrade
  • Update system for pDAO

Related issue(s)

closes: #35

Motivation and Context

  1. To avoid trader dissatisfaction with constant migrations due to Synthetix v3 upgrades
  2. Add solution to complexity mistakes associated w/ end-users or Kwenta (worst-case scenario tool)

@JaredBorders JaredBorders added enhancement New feature or request smart-contracts labels Dec 20, 2023
@JaredBorders JaredBorders self-assigned this Dec 20, 2023
@JaredBorders JaredBorders marked this pull request as ready for review December 20, 2023 01:17
tommyrharper
tommyrharper approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@tommyrharper tommyrharper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, nice work 🔥 - I know it's been a long journey with the SMv3 changes, well done for getting to this point, it's a tricky system! 🎉 🥳 🍾

@JaredBorders
Copy link
Contributor Author

All good, nice work 🔥 - I know it's been a long journey with the SMv3 changes, well done for getting to this point, it's a tricky system! 🎉 🥳 🍾

Ty man! It was a group effort for sure! 🤝

@JaredBorders JaredBorders merged commit c5e1078 into main Dec 20, 2023
3 of 4 checks passed
@JaredBorders JaredBorders deleted the 35-Upgradable branch December 20, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyrharper tommyrharper tommyrharper approved these changes

@jcmonte jcmonte Awaiting requested review from jcmonte

Assignees

@JaredBorders JaredBorders

Labels
enhancement New feature or request smart-contracts
Projects
Kwenta Smart Contracts
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

👷🏻‍♂️ Make Engine Upgradable
2 participants
@JaredBorders @tommyrharper