Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not continue to delegate after finalize initiation #519

Merged
merged 1 commit into from
Jan 21, 2025
+4 −0
Merged

Do not continue to delegate after finalize initiation #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/go/internal/privatetxnmgr/transaction_flow_actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ func (tf *transactionFlow) Action(ctx context.Context) {
//we know we need to finalize but we are not currently waiting for a finalize to complete
// most likely a previous attempt to finalize has failed
tf.finalize(ctx)
tf.logActionInfo(ctx, "finalize initiated")
return
}

if tf.dispatched {
Expand Down Expand Up @@ -284,6 +286,8 @@ func (tf *transactionFlow) finalize(ctx context.Context) {
go tf.publisher.PublishTransactionFinalizeError(ctx, tf.transaction.ID.String(), tf.finalizeRevertReason, rollbackErr)
},
)

tf.finalizePending = true
}

func (tf *transactionFlow) delegateIfRequired(ctx context.Context) (doContinue bool) {
Expand Down
Loading